Merged
Conversation
tomasfejfar
previously requested changes
May 3, 2024
Contributor
tomasfejfar
left a comment
tomasfejfar
left a comment
There was a problem hiding this comment.
This needs intergration test with an actual api.
- create table
- create config
- create trigger on the table to trigger the config
- run import against the table
- assert lastRun ofthe trigger
Contributor
Author
Should I really test the triggering mechanism? That does not seems to be the responsibility of this library. |
Contributor
Or you could somehow verify that the trigger is set up correctly. |
odinuv
approved these changes
May 9, 2024
Member
odinuv
left a comment
odinuv
left a comment
There was a problem hiding this comment.
i think it's ok, just please fix the bucket id in test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.